Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow custom lazyCompilation.backend.client #8934

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

colinaaa
Copy link
Collaborator

@colinaaa colinaaa commented Jan 4, 2025

Summary

There is an option experiments.lazyCompilation.backend.client that can specify custom client of LazyCompilation.

But it doesn't seem to work since it will always be overwritten by hot/lazy-compilation-web.js or hot/lazy-compilation-node.js

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jan 4, 2025
Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1276e25
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6779335ec6bcd70008b9a87c

Copy link

codspeed-hq bot commented Jan 4, 2025

CodSpeed Performance Report

Merging #8934 will not alter performance

Comparing colinaaa:main (1276e25) with main (99f77c8)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@chenjiahan chenjiahan requested a review from JSerFeng January 4, 2025 13:34
@JSerFeng
Copy link
Contributor

JSerFeng commented Jan 4, 2025

Thank u !

@JSerFeng JSerFeng merged commit f81f1c7 into web-infra-dev:main Jan 4, 2025
34 checks passed
@h-a-n-a h-a-n-a mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants