Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clean up unused dev dependencies #8919

Merged
merged 3 commits into from
Jan 2, 2025
Merged

test: clean up unused dev dependencies #8919

merged 3 commits into from
Jan 2, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jan 2, 2025 •
edited
Loading

Summary

Remove unused dev dependencies from tests/webpack-examples/package.json and tests/webpack-test/package.json to make CI faster.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 2, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 2, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bb35faa
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67763767167d210008cda2e5

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #8919 will not alter performance

Comparing clean_up_dev_deps_1231 (bb35faa) with main (d2721e9)

Summary

✅ 3 untouched benchmarks

@chenjiahan chenjiahan merged commit aa8732c into main Jan 2, 2025
40 checks passed
@chenjiahan chenjiahan deleted the clean_up_dev_deps_1231 branch January 2, 2025 07:40
@h-a-n-a h-a-n-a mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoonIter SoonIter SoonIter approved these changes

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @SoonIter