Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve FlagDependencyExportsPlugin for large JSON by depth #8802

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

hai-x
Copy link
Contributor

@hai-x hai-x commented Dec 21, 2024

Summary

Aligned with webpack/webpack#19058.

I will update doc later.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Dec 21, 2024
Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 610aaf0
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676977f8710fa600088250b9

@hai-x hai-x force-pushed the hai-x/feat-support-dyn-exp-for-url branch from 84ce1e2 to cad432f Compare December 22, 2024 06:12
Copy link

codspeed-hq bot commented Dec 22, 2024

CodSpeed Performance Report

Merging #8802 will not alter performance

Comparing hai-x:hai-x/feat-support-dyn-exp-for-url (610aaf0) with main (a4aa3a9)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@LingyuCoder LingyuCoder requested a review from JSerFeng December 23, 2024 01:54
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

crates/rspack_plugin_json/src/json_exports_dependency.rs Outdated Show resolved Hide resolved
crates/rspack_plugin_json/src/lib.rs Outdated Show resolved Hide resolved
packages/rspack/src/config/defaults.ts Outdated Show resolved Hide resolved
@hai-x hai-x requested a review from ahabhgk December 23, 2024 14:19
@hai-x hai-x force-pushed the hai-x/feat-support-dyn-exp-for-url branch from bb05fe4 to 610aaf0 Compare December 23, 2024 14:47
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahabhgk ahabhgk merged commit 89f567b into web-infra-dev:main Dec 24, 2024
32 checks passed
@hai-x hai-x deleted the hai-x/feat-support-dyn-exp-for-url branch December 24, 2024 12:38
@hai-x
Copy link
Contributor Author

hai-x commented Dec 30, 2024

Update to 1.2.0-alpha.0 and found that

when module.parser.json.exportsDepth: Number.MAX_SAFE_INTEGER

$ rspack build --config dev.config.js
Rspack compiled successfully in 1.94 s
✨  Done in 2.94s.

when module.parser.json.exportsDepth: 1

$ rspack build --config dev.config.js
Rspack compiled successfully in 505 ms
✨  Done in 1.34s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants