Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persistent cache in production mode wait for save to complete #8777

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jerrykingxyz
Copy link
Contributor

Summary

  1. Persistent cache waits for storage saves to complete in production mode and exposes errors to compile diagnostics.
  2. Persistent cache in development mode does not wait for save to complete, only prints storage errors when it ends.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit edcf14d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6763f1c7affd4a00086c62ad

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #8777 will not alter performance

Comparing jerrykingxyz:cache (edcf14d) with main (22f3bb0)

Summary

✅ 1 untouched benchmarks

@LingyuCoder LingyuCoder merged commit 292f728 into web-infra-dev:main Dec 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants