Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: improve cached source data struct #8602

Merged
merged 6 commits into from
Dec 4, 2024
Merged

perf: improve cached source data struct #8602

merged 6 commits into from
Dec 4, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 3, 2024 •
edited by h-a-n-a
Loading

Summary

Relative:

  1. perf: improve source map data struct rspack-sources#123
  2. perf: remove cache in replace source rspack-sources#124

Hash updated due to web-infra-dev/rspack-sources#128

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SyMind
Copy link
Member Author

SyMind commented Dec 3, 2024

!bench

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 3, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7868c4a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6750052e5dc8d900084c094a

@rspack-bot
Copy link

rspack-bot commented Dec 3, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-12-03 2ec1cf5) Current Change
10000_big_production-mode_disable-minimize + exec 42.1 s ± 1.03 s 38.1 s ± 974 ms -9.56 %
10000_development-mode + exec 1.79 s ± 11 ms 1.78 s ± 25 ms -0.49 %
10000_development-mode_hmr + exec 647 ms ± 8.7 ms 641 ms ± 4.2 ms -0.89 %
10000_production-mode + exec 2.4 s ± 44 ms 2.39 s ± 13 ms -0.61 %
arco-pro_development-mode + exec 1.76 s ± 92 ms 1.73 s ± 73 ms -1.50 %
arco-pro_development-mode_hmr + exec 425 ms ± 1.9 ms 426 ms ± 2.4 ms +0.22 %
arco-pro_production-mode + exec 3.1 s ± 67 ms 3.08 s ± 69 ms -0.65 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.15 s ± 71 ms 3.15 s ± 81 ms +0.13 %
threejs_development-mode_10x + exec 1.62 s ± 15 ms 1.61 s ± 31 ms -0.77 %
threejs_development-mode_10x_hmr + exec 808 ms ± 7.7 ms 797 ms ± 19 ms -1.33 %
threejs_production-mode_10x + exec 4.9 s ± 17 ms 4.9 s ± 23 ms -0.00 %
10000_big_production-mode_disable-minimize + rss memory 13327 MiB ± 247 MiB 11689 MiB ± 351 MiB -12.29 %
10000_development-mode + rss memory 778 MiB ± 24.5 MiB 757 MiB ± 17.4 MiB -2.75 %
10000_development-mode_hmr + rss memory 2088 MiB ± 261 MiB 1943 MiB ± 416 MiB -6.93 %
10000_production-mode + rss memory 665 MiB ± 30.3 MiB 666 MiB ± 49.3 MiB +0.06 %
arco-pro_development-mode + rss memory 731 MiB ± 23.7 MiB 698 MiB ± 38.5 MiB -4.57 %
arco-pro_development-mode_hmr + rss memory 904 MiB ± 67.8 MiB 917 MiB ± 101 MiB +1.54 %
arco-pro_production-mode + rss memory 849 MiB ± 52.5 MiB 839 MiB ± 46.2 MiB -1.19 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 848 MiB ± 54.4 MiB 844 MiB ± 60.1 MiB -0.49 %
threejs_development-mode_10x + rss memory 817 MiB ± 47.2 MiB 779 MiB ± 34.7 MiB -4.62 %
threejs_development-mode_10x_hmr + rss memory 2170 MiB ± 202 MiB 1790 MiB ± 141 MiB -17.49 %
threejs_production-mode_10x + rss memory 1033 MiB ± 67.6 MiB 1052 MiB ± 48.7 MiB +1.78 %

@SyMind
Copy link
Member Author

SyMind commented Dec 3, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Dec 3, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-12-03 2ec1cf5) Current Change
10000_big_production-mode_disable-minimize + exec 42.1 s ± 1.03 s 37.1 s ± 181 ms -11.83 %
10000_development-mode + exec 1.79 s ± 11 ms 1.8 s ± 38 ms +0.38 %
10000_development-mode_hmr + exec 647 ms ± 8.7 ms 642 ms ± 5.8 ms -0.79 %
10000_production-mode + exec 2.4 s ± 44 ms 2.38 s ± 21 ms -1.15 %
arco-pro_development-mode + exec 1.76 s ± 92 ms 1.75 s ± 48 ms -0.64 %
arco-pro_development-mode_hmr + exec 425 ms ± 1.9 ms 426 ms ± 2 ms +0.08 %
arco-pro_production-mode + exec 3.1 s ± 67 ms 3.1 s ± 80 ms -0.17 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.15 s ± 71 ms 3.16 s ± 86 ms +0.36 %
threejs_development-mode_10x + exec 1.62 s ± 15 ms 1.61 s ± 14 ms -0.56 %
threejs_development-mode_10x_hmr + exec 808 ms ± 7.7 ms 798 ms ± 10 ms -1.24 %
threejs_production-mode_10x + exec 4.9 s ± 17 ms 4.9 s ± 38 ms -0.03 %
10000_big_production-mode_disable-minimize + rss memory 13327 MiB ± 247 MiB 10344 MiB ± 91 MiB -22.38 %
10000_development-mode + rss memory 778 MiB ± 24.5 MiB 752 MiB ± 23.3 MiB -3.30 %
10000_development-mode_hmr + rss memory 2088 MiB ± 261 MiB 1990 MiB ± 99.8 MiB -4.67 %
10000_production-mode + rss memory 665 MiB ± 30.3 MiB 661 MiB ± 41.1 MiB -0.71 %
arco-pro_development-mode + rss memory 731 MiB ± 23.7 MiB 698 MiB ± 32.7 MiB -4.60 %
arco-pro_development-mode_hmr + rss memory 904 MiB ± 67.8 MiB 912 MiB ± 99.5 MiB +0.98 %
arco-pro_production-mode + rss memory 849 MiB ± 52.5 MiB 825 MiB ± 43.5 MiB -2.82 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 848 MiB ± 54.4 MiB 812 MiB ± 55.1 MiB -4.27 %
threejs_development-mode_10x + rss memory 817 MiB ± 47.2 MiB 762 MiB ± 52.3 MiB -6.70 %
threejs_development-mode_10x_hmr + rss memory 2170 MiB ± 202 MiB 1700 MiB ± 97.5 MiB -21.66 %
threejs_production-mode_10x + rss memory 1033 MiB ± 67.6 MiB 1098 MiB ± 71.7 MiB +6.23 %

@SyMind SyMind changed the title perf: cached source perf: improve cached source data struct Dec 3, 2024
@h-a-n-a h-a-n-a marked this pull request as ready for review December 4, 2024 06:22
h-a-n-a
h-a-n-a previously approved these changes Dec 4, 2024
View reviewed changes
@h-a-n-a h-a-n-a enabled auto-merge (squash) December 4, 2024 06:22
h-a-n-a
h-a-n-a previously approved these changes Dec 4, 2024
View reviewed changes
@h-a-n-a h-a-n-a merged commit 1b9da9e into main Dec 4, 2024
32 checks passed
@h-a-n-a h-a-n-a deleted the perf-cached-source branch December 4, 2024 08:19
@chenjiahan chenjiahan mentioned this pull request Dec 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees

@SyMind SyMind

Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyMind @rspack-bot @h-a-n-a