Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rule.issuerLayer #8572

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: rule.issuerLayer #8572

merged 3 commits into from
Nov 29, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Nov 29, 2024

Summary

Fix isserLayer and issuer match wrong when layer and issuer of target dependency are empty.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 29, 2024
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4c57b12
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67494326a1ee310008b780d0

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 29, 2024
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #8572 will not alter performance

Comparing rule.issuerLayer (4c57b12) with main (5f77de0)

Summary

✅ 1 untouched benchmarks

@SyMind SyMind marked this pull request as ready for review November 29, 2024 04:29
@SyMind SyMind merged commit deb10b9 into main Nov 29, 2024
33 checks passed
@SyMind SyMind deleted the rule.issuerLayer branch November 29, 2024 05:46
@chenjiahan
Copy link
Member

I suggest the PR title can be more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants