Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chunk render cache panic on css extract diagnostics #8562

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Nov 28, 2024

Summary

Don't cache diagnostics for chunk render cache

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk enabled auto-merge (squash) November 28, 2024 10:24
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Nov 28, 2024
@ahabhgk ahabhgk requested a review from JSerFeng November 28, 2024 10:24
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 47c8854
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674844d2e9875600083abfa8

Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #8562 will not alter performance

Comparing fix-chunk-render-cache-css-panic (47c8854) with main (21edaba)

Summary

✅ 1 untouched benchmarks

@ahabhgk ahabhgk merged commit 5f77de0 into main Nov 28, 2024
37 checks passed
@ahabhgk ahabhgk deleted the fix-chunk-render-cache-css-panic branch November 28, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants