Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rspack_cacheable support rspack_sources::BoxSource #8527

Merged
merged 2 commits into from
Nov 25, 2024
Merged

feat: rspack_cacheable support rspack_sources::BoxSource #8527

merged 2 commits into from
Nov 25, 2024

Conversation

jerrykingxyz
Copy link
Contributor

Summary

This PR rewrites support for rspack_sources::BoxSource in AsPreset

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 25, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 25, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3aecb2e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674462cba3f551000835ba77

@jerrykingxyz jerrykingxyz requested a review from SyMind November 25, 2024 11:38
SyMind
SyMind previously approved these changes Nov 25, 2024
View reviewed changes
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #8527 will not alter performance

Comparing jerry/cacheable (3aecb2e) with main (f6763a9)

Summary

✅ 1 untouched benchmarks

@jerrykingxyz jerrykingxyz enabled auto-merge (squash) November 25, 2024 11:51
@jerrykingxyz jerrykingxyz merged commit b09e6b9 into main Nov 25, 2024
32 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/cacheable branch November 25, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyMind SyMind SyMind approved these changes

Assignees

@jerrykingxyz jerrykingxyz

Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerrykingxyz @SyMind