Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: variable name conflict with concatenate and runtime code #8386

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: variable name conflict with concatenate and runtime code #8386

merged 1 commit into from
Nov 25, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Nov 9, 2024

Summary

See webpack/webpack#18932 for background.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 9, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 9, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7126c66
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672f85f8d33a7800084748c8

@inottn inottn force-pushed the fix/variable-name-conflict branch from 81e69ca to 7126c66 Compare November 9, 2024 15:55
@chenjiahan chenjiahan requested a review from JSerFeng November 25, 2024 10:01
chenjiahan
chenjiahan approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit b753080 into web-infra-dev:main Nov 25, 2024
29 checks passed
@inottn inottn deleted the fix/variable-name-conflict branch November 25, 2024 10:07
@renovate renovate bot mentioned this pull request Dec 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narretz Narretz Narretz left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inottn @Narretz @chenjiahan