Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use symlinked executables instead of command shims #8382

Merged
merged 1 commit into from
Nov 8, 2024
Merged

build: use symlinked executables instead of command shims #8382

merged 1 commit into from
Nov 8, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Nov 8, 2024 •
edited
Loading

Summary

THIS DOES NOT WORK ON WINDOWS.

See: https://pnpm.io/npmrc#prefer-symlinked-executables

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 8, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b7bfad6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672deccf2c20ca00082d4ae8

@h-a-n-a h-a-n-a marked this pull request as ready for review November 8, 2024 11:00
@h-a-n-a h-a-n-a requested review from SoonIter and hardfist November 8, 2024 11:00
@h-a-n-a h-a-n-a enabled auto-merge (squash) November 8, 2024 11:01
@h-a-n-a h-a-n-a merged commit 2ac4a11 into main Nov 8, 2024
37 checks passed
@h-a-n-a h-a-n-a deleted the pnpm-symlink-exe branch November 8, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoonIter SoonIter SoonIter approved these changes

@hardfist hardfist Awaiting requested review from hardfist

Assignees

@h-a-n-a h-a-n-a

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @SoonIter