Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rspack_fs use Utf8Path and FileMetadata #8366

Merged
merged 1 commit into from
Nov 8, 2024
Merged

refactor: rspack_fs use Utf8Path and FileMetadata #8366

merged 1 commit into from
Nov 8, 2024

Conversation

jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Nov 7, 2024 •
edited
Loading

Summary

  • update ReadableFileSystem trait to use Utf8Path and Utf8PathBuf
    In rspack we use Utf8Path and Utf8PathBuf instead of Path and PathBuf. more info see refactor: drop support for non-UTF8 paths #7570

  • define FileMetadata to replace Metadata to make Async and Sync trait return same struct

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 7, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit b3ffc46
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672c6ce053928f000890c4b0
😎 Deploy Preview https://deploy-preview-8366--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hardfist
Copy link
Contributor

hardfist commented Nov 7, 2024 •
edited
Loading

@jerrykingxyz can you help explain why change Path to Utf8Path in Filesystem trait here?
Path & PathBuf seems more standard as a rust api interface

@h-a-n-a h-a-n-a changed the title refactor: rspack_fs use utf8path and filemetadata refactor: rspack_fs use Utf8Path and FileMetadata Nov 8, 2024
@jerrykingxyz jerrykingxyz merged commit b77d7de into main Nov 8, 2024
63 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/fs branch November 8, 2024 06:10
@jerrykingxyz jerrykingxyz mentioned this pull request Nov 18, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees

@jerrykingxyz jerrykingxyz

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerrykingxyz @hardfist @h-a-n-a