Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): missing exports.types field #8355

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(cli): missing exports.types field #8355

merged 1 commit into from
Nov 6, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Nov 6, 2024 •
edited
Loading

Summary

@rspack/cli has been converted to a "dual package" and the exports.types is required to provide typing for the dist/index.mjs.

#8187

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 6, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 6, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 36bd5fc
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672b23b4f2f9ab000893ee1e

@chenjiahan chenjiahan merged commit 8b4dcce into main Nov 6, 2024
38 checks passed
@chenjiahan chenjiahan deleted the cli_types_1106 branch November 6, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees

@chenjiahan chenjiahan

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @Timeless0911