-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use incremental in production build #8311
Conversation
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
When incremental becomes more stable, we can provide more optimal defaults to reduce the burden on users to understand these configurations.
I tried incremental true in facebook/docusaurus#10648 I got the following warnings, despite not configuring
The error doesn't make it super clear to understand what is happening and what I should do. Rereading the docs/blog post it's quite obvious: I'll disable this in prod builds. |
Summary
fix #8106 (comment)
Before using
incremental: true
will panic in production build, caused by concatenateModules, this is expected but we should have better experience, so this PR will disableincremental.moduleHashes/moduleCodegen/moduleRuntimeRequirements
when using with concatenateModules/usedExports/mangleExports, and log warnings.And the docs is also updated to recommend user to only enable incremental in development mode.
Checklist