Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify module in loader context #8262

Merged
merged 8 commits into from
Nov 1, 2024
Merged

feat: unify module in loader context #8262

merged 8 commits into from
Nov 1, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Oct 30, 2024

Summary

Replace CompilerModuleContext and JsCompilerModuleContext with Module and JsModule.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Oct 30, 2024
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 925c664
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67245bfb9dd341000812f5b8

@web-infra-dev web-infra-dev deleted a comment from rspack-bot Nov 1, 2024
@SyMind SyMind changed the title perf: module in loader context feat: unify module in loader context Nov 1, 2024
@github-actions github-actions bot added release: feature release: feature related release(mr only) and removed release: performance release: performance related release(mr only) labels Nov 1, 2024
@SyMind
Copy link
Member Author

SyMind commented Nov 1, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Nov 1, 2024

📝 Benchmark detail: Open

Name Base (2024-11-01 4aeee85) Current Change
10000_big_production-mode + exec 47.5 s ± 1.45 s 48.4 s ± 1.37 s +1.75 %
10000_development-mode + exec 2.08 s ± 13 ms 2.08 s ± 16 ms +0.15 %
10000_development-mode_hmr + exec 649 ms ± 13 ms 645 ms ± 3.9 ms -0.61 %
10000_production-mode + exec 2.62 s ± 29 ms 2.61 s ± 33 ms -0.25 %
arco-pro_development-mode + exec 1.78 s ± 79 ms 1.78 s ± 59 ms +0.31 %
arco-pro_development-mode_hmr + exec 428 ms ± 1.1 ms 428 ms ± 2 ms 0.00 %
arco-pro_production-mode + exec 3.22 s ± 82 ms 3.2 s ± 76 ms -0.43 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.22 s ± 79 ms 3.28 s ± 78 ms +1.69 %
threejs_development-mode_10x + exec 1.64 s ± 12 ms 1.58 s ± 11 ms -3.76 %
threejs_development-mode_10x_hmr + exec 784 ms ± 14 ms 782 ms ± 15 ms -0.18 %
threejs_production-mode_10x + exec 5.03 s ± 52 ms 4.97 s ± 30 ms -1.23 %

@SyMind SyMind marked this pull request as ready for review November 1, 2024 06:27
@SyMind SyMind requested a review from jerrykingxyz as a code owner November 1, 2024 06:27
@SyMind SyMind merged commit 3e3bacb into main Nov 1, 2024
30 checks passed
@SyMind SyMind deleted the loader-context-module branch November 1, 2024 06:33
@SyMind
Copy link
Member Author

SyMind commented Nov 1, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Nov 1, 2024

📝 Ran ecosystem CI: Open

suite result
${{ matrix.suite }} undefined skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants