Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix link is 404 in Guide #8223

Merged
merged 2 commits into from
Oct 26, 2024
Merged

docs: fix link is 404 in Guide #8223

merged 2 commits into from
Oct 26, 2024
+4 −4

Conversation

nobuaki0331
Copy link
Contributor

@nobuaki0331 nobuaki0331 commented Oct 26, 2024 •
edited
Loading

Summary

I found some broken links in the Guide and have corrected them.

I kindly ask for your confirmation.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: document release: document related release(mr only) label Oct 26, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cce6a78
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671c9ed6cad9970008d3bba5
😎 Deploy Preview https://deploy-preview-8223--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan enabled auto-merge (squash) October 26, 2024 09:51
@chenjiahan chenjiahan merged commit 6b70c32 into web-infra-dev:main Oct 26, 2024
38 checks passed
@nobuaki0331 nobuaki0331 deleted the fix/link-to-rsbuild branch November 5, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: document release: document related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nobuaki0331 @CLAassistant @chenjiahan