fix: preserve star export from external module #8217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #8206.
Overall changes:
"module"
or"module-import"
will makeexport *
classified as a newExportModeType::ReexportFrom
. This type will not introduce runtime.export * from 'x'
from be added inmodern-module
by a new dependency."module"
external type, all star export will wrongly be assigned to the default export of the entry which is totally a wrong result. In this PR,export *
will not work anymore.output of previous implementation with
export * from 'react'; export * from 'vue';
, react and vue are externalized with type"module".
Checklist