Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): trigger pkg-preview when the needs are skipped #8216

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(ci): trigger pkg-preview when the needs are skipped #8216

merged 1 commit into from
Oct 25, 2024

Conversation

shulaoda
Copy link
Collaborator

@shulaoda shulaoda commented Oct 25, 2024 •
edited
Loading

Summary

Trigger pkg-preview when the dependent jobs are skipped as well.

I noticed that sometimes pkg-preview gets skipped because the dependent jobs rust_check and rust_test are skipped.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 25, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 25, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit be9823e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671b41cea14a5e0008da0fd1

@shulaoda shulaoda requested review from chenjiahan and SoonIter and removed request for jerrykingxyz October 25, 2024 06:59
@SoonIter SoonIter enabled auto-merge (squash) October 25, 2024 09:19
@SoonIter SoonIter merged commit c29c6dc into web-infra-dev:main Oct 25, 2024
36 checks passed
@shulaoda shulaoda deleted the fix/ci-pkg-preview branch October 25, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoonIter SoonIter SoonIter approved these changes

@chenjiahan chenjiahan Awaiting requested review from chenjiahan

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shulaoda @SoonIter