Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(snapshot): make snapshots cleaner and update path-serializer 0.3.4 #8161

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Oct 17, 2024

Summary

1. Update the path-serializer dependency from version 0.1.2 to 0.3.4 in package.json.

  1. replace root cleaner
<ROOT>: `/xx/local/rspack`
<TEST_TOOLS_ROOT>: `/xx/local/rspack/packages/test-tools`
<RSPACK_ROOT>: `/xx/local/rspack/packages/rspack`
  1. feat: escape EOL "\r\n" -> "\n"
  2. feat: normalizeCLR for ansi colors
  3. fix: esm import type error
  4. preserve "\" rather than "/"
  5. remove replacePaths escapeEOL normalizeCLR

2. add this.serializeEachFile method to treeshakingSnapshotProcessor and snapshotProcessor

  • allow path-serializer to serialize custom snapshot file treeshaking.snap.txt

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4bc1d68
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674fe6e92262c90008bb5bda

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 17, 2024
@SoonIter SoonIter force-pushed the snapshot branch 3 times, most recently from d07f905 to 95fb921 Compare November 29, 2024 06:56
@SoonIter SoonIter changed the title test: update the snapshot test(snapshot): make snapshots cleaner and update path-serializer Dec 2, 2024
@SoonIter SoonIter force-pushed the snapshot branch 2 times, most recently from 1dd4a2b to f30a35c Compare December 3, 2024 10:06
@SoonIter SoonIter changed the title test(snapshot): make snapshots cleaner and update path-serializer test(snapshot): make snapshots cleaner and update path-serializer 0.3.4 Dec 4, 2024
@SoonIter SoonIter marked this pull request as ready for review December 4, 2024 06:19
@chenjiahan chenjiahan merged commit 89ddc85 into main Dec 4, 2024
40 checks passed
@chenjiahan chenjiahan deleted the snapshot branch December 4, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants