feat(rust): add output.sourceMapFilename core #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippzhang
requested review from
hardfist,
ahabhgk,
JSerFeng,
h-a-n-a,
hyf0 and
IWANABETHATGUY
as code owners
|
lippzhang
force-pushed
the
feature/sourceMapFilename-lippzhang
branch
4 times, most recently
from
5e0f7b6 to
1ef383e
Compare
lippzhang
force-pushed
the
feature/sourceMapFilename-lippzhang
branch
3 times, most recently
from
1bbf5c0 to
0c50070
Compare
|
General looks good to me, ready to merge after rebase |
lippzhang
commented
May 6, 2023
lippzhang
force-pushed
the
feature/sourceMapFilename-lippzhang
branch
3 times, most recently
from
28156f6 to
eeeda76
Compare
lippzhang
force-pushed
the
feature/sourceMapFilename-lippzhang
branch
from
eeeda76 to
e2a9fe3
Compare
have rebase main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
#2938
Summary
Manage the output path of source map files
https://webpack.js.org/configuration/output/#outputsourcemapfilename
🤖 Generated by Copilot at 0cf70ca
This pull request adds a new option
sourceMapFilenameto therspackconfiguration file, which allows users to customize the filename of the source map files generated by therspack_plugin_devtoolplugin. It implements this option in therspack_core,rspack_binding_options,rspack_plugin_devtool, andrspack_testingcrates, and updates the JSON schema and typescript types for therspackconfiguration file. It also makes some minor code improvements and updates thepackage.jsonfile.Walkthrough
🤖 Generated by Copilot at 0cf70ca
source_map_filenameoption to therspackconfiguration file and therspack_corecrate to allow users to configure the output filename of the source map files generated by therspack_plugin_devtoolplugin (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)[file]placeholder syntax for thesource_map_filenameoption to support the original filename in the template, similar towebpack(link, link)devtooloption and thepublic_pathoption in therspack_plugin_devtoolplugin to handle different modes and paths for the source map files (link)..Default::default()syntax for theAssetInfostruct initialization in therspack_plugin_asset,rspack_plugin_copy, andrspack_plugin_htmlplugins to improve the code readability and maintainability (link, link, link, link)source-mapfeature in thewebpack-testdirectory (link, link)