Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x.mjs): add x clean command #2980

Merged
merged 1 commit into from
May 4, 2023
Merged

feat(x.mjs): add x clean command #2980

merged 1 commit into from
May 4, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Apr 28, 2023

Related issue (if exists)

Summary

🤖 Generated by Copilot at 1d14481

Added a new command and improved the script execution for x, a tool for managing Node.js and Rust projects. Switched to using zx for running the x script in package.json to leverage its features and compatibility.

Walkthrough

🤖 Generated by Copilot at 1d14481

  • Use zx instead of ./x.mjs to run the x script in package.json for portability and consistency (link)
  • Add x clean command to x.mjs to clean node_modules and target directories with subcommands all, node, and rust (link)
  • Update argument parsing logic in x.mjs to handle different ways of calling the script from pnpm x or zx x.mjs (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023

⚠️ No Changeset found

Latest commit: 2d1c18e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Boshen Boshen requested a review from hyf0 April 28, 2023 09:00
@github-actions github-actions bot added release: feature team The issue/pr is created by the member of Rspack. labels Apr 28, 2023
x.mjs Outdated Show resolved Hide resolved
@Boshen Boshen requested a review from hardfist May 4, 2023 02:36
@Boshen Boshen changed the title feat(x.mjs): add x clean along with x clean node and x clean rust commands feat(x.mjs): add x clean command May 4, 2023
@Boshen Boshen enabled auto-merge May 4, 2023 03:25
@Boshen Boshen added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit aa32a97 May 4, 2023
@Boshen Boshen deleted the x-script branch May 4, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants