Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 unexpected export warning #2959

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix: 🐛 unexpected export warning #2959

merged 1 commit into from
Apr 27, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Apr 27, 2023 •
edited by ghost
Loading

Related issue (if exists)

Summary

🤖 Generated by Copilot at 7da7541

Refactor tree shaking visitor to support different module syntaxes and dependency types. Update visit_call_expr to use ModuleSyntax::COMMONJS for require calls.

Walkthrough

🤖 Generated by Copilot at 7da7541

  • Refactor the tree shaking visitor to support different module syntaxes and dependency types (link, F

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7da7541

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added release: bug fix team The issue/pr is created by the member of Rspack. labels Apr 27, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 27, 2023 08:52
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 27, 2023
Merged via the queue into main with commit 18dbdb4 Apr 27, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the fix/unexpect-warning branch April 27, 2023 09:00
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
@IWANABETHATGUY @siyou
fix: 🐛 unexpected export warning (web-infra-dev#2959)
9e6257c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @jerrykingxyz