Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve): delay the directory check in exportsFieldPlugin #2883

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Apr 23, 2023

fix the bug that check request directory in the beginning of exportsFiledPlugin.

example:

require('lib/'); // it may failed because it request a directory and it a bug of resolve

Summary

🤖 Generated by Copilot at 143cd53

Updated nodejs-resolver to fix module loading bug. This dependency is used by Cargo.toml to resolve Node.js modules for Rust projects.

Walkthrough

🤖 Generated by Copilot at 143cd53

  • Update nodejs-resolver dependency to fix module loading bug (link)

@bvanjoi bvanjoi requested a review from h-a-n-a as a code owner April 23, 2023 09:28
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023

⚠️ No Changeset found

Latest commit: 143cd53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added release: bug fix team The issue/pr is created by the member of Rspack. labels Apr 23, 2023
@hardfist hardfist enabled auto-merge April 23, 2023 10:09
@hardfist hardfist added this pull request to the merge queue Apr 23, 2023
Merged via the queue into main with commit bc820a4 Apr 23, 2023
@hardfist hardfist deleted the test-resource-query-rule branch April 23, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants