Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: should exit if the exitCode is not zero at check_changeset.js #2880

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Apr 23, 2023

Related issue (if exists)

Summary

🤖 Generated by Copilot at 2e6fc6e

Improved error handling for checkBump function in scripts/check_changeset.js. The function now checks the exit code of pnpm changeset version and exits with an error message if it fails.

Walkthrough

🤖 Generated by Copilot at 2e6fc6e

  • Add a check for the exit code of pnpm changeset version and exit with an error message if it is not zero (link)

@hyf0 hyf0 requested a review from Boshen as a code owner April 23, 2023 07:17
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023

⚠️ No Changeset found

Latest commit: 2e6fc6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hyf0 hyf0 requested review from chenjiahan and removed request for Boshen April 23, 2023 07:17
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 23, 2023
@hyf0 hyf0 enabled auto-merge April 23, 2023 07:18
@hyf0 hyf0 added this pull request to the merge queue Apr 23, 2023
Merged via the queue into main with commit 043b9ff Apr 23, 2023
@hyf0 hyf0 deleted the 1203e812904809182930 branch April 23, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants