Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix peerDep of rspack-plugin-html #2876

Merged
merged 2 commits into from
Apr 23, 2023
Merged

chore: fix peerDep of rspack-plugin-html #2876

merged 2 commits into from
Apr 23, 2023

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Apr 23, 2023

Related issue (if exists)

fixes #2852

Summary

🤖 Generated by Copilot at 44c7269

Remove local dependencies on @rspack/core from pnpm-lock.yaml. This improves the stability and compatibility of the web-infra-dev/rspack packages.

Walkthrough

🤖 Generated by Copilot at 44c7269

  • Remove local dependencies on @rspack/core from @rspack/cli and @rspack/webpack packages (link, link) in pnpm-lock.yaml

@hardfist hardfist requested a review from ahabhgk as a code owner April 23, 2023 06:21
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023

🦋 Changeset detected

Latest commit: e49e1d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@rspack/plugin-html Patch
@rspack/postcss-loader Patch
@rspack/cli Patch
@rspack/dev-client Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/core Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch
webpack-test Patch
benchmarkcase-rspack-react-refresh Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 23, 2023
@hardfist hardfist force-pushed the fix-peer branch 2 times, most recently from 44c7269 to 8f35281 Compare April 23, 2023 07:40
@hardfist hardfist added this pull request to the merge queue Apr 23, 2023
Merged via the queue into main with commit 0e23d72 Apr 23, 2023
@hardfist hardfist deleted the fix-peer branch April 23, 2023 09:23
@github-actions github-actions bot mentioned this pull request Apr 25, 2023
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
* chore: fix peerDep of rspack-plugin-html

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rspack/plugin-html has direct dependency on @rspack/core -- should it be peer?
3 participants