Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime): unwrap the function in ir #2860

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Apr 21, 2023

Related issue (if exists)

Summary

🤖 Generated by Copilot at 9fda91d

This pull request refactors and optimizes the runtime code of the rspack plugin. It removes unnecessary function wrappers, moves some functions to the main runtime file, and reduces the number of files and imports. These changes aim to improve the performance, readability, and maintainability of the runtime code.

Walkthrough

🤖 Generated by Copilot at 9fda91d

  • Simplify and optimize the runtime code by moving and removing self-invoking function wrappers (link, link)
  • Consolidate the _getRequireCache and __webpack_require__.ir functions into the main runtime/common/_interop_require.js file (link)
  • Update the dynamic-import test fixture to reflect the changes in the runtime code (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023

⚠️ No Changeset found

Latest commit: 9fda91d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 21, 2023
@bvanjoi bvanjoi added this pull request to the merge queue Apr 22, 2023
Merged via the queue into main with commit f2e4f51 Apr 22, 2023
@bvanjoi bvanjoi deleted the unwrap-ir-runtime branch April 22, 2023 01:14
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants