Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: share rust target directory in check-rs #2818

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Apr 19, 2023

Related issue (if exists)

Summary

🤖 Generated by Copilot at 807214a

This pull request adds a build configuration option to share the target directory for the cargo build command across the project. This improves the integration of the node_binding crate with the RSPack server.

Walkthrough

🤖 Generated by Copilot at 807214a

  • Add build configuration option to share target directory for Node.js binding (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

⚠️ No Changeset found

Latest commit: 535f408

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 19, 2023
@Boshen Boshen force-pushed the same-target-directory branch from 4a25529 to f602890 Compare April 19, 2023 06:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Boshen Boshen force-pushed the same-target-directory branch from f602890 to 535f408 Compare April 19, 2023 06:38
@Boshen Boshen changed the title chore: make ./crates/node_binding share the same target root directory ci: share rust target directory in check-rs Apr 19, 2023
@Boshen Boshen marked this pull request as ready for review April 19, 2023 06:38
@Boshen
Copy link
Contributor Author

Boshen commented Apr 19, 2023

I think it's safe for us to remove --release because we don't use any release feature flags, it should help with the slow ci run.

@Boshen Boshen added this pull request to the merge queue Apr 19, 2023
Merged via the queue into main with commit 5e181f2 Apr 19, 2023
@Boshen Boshen deleted the same-target-directory branch April 19, 2023 06:54
IWANABETHATGUY pushed a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants