Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: only cache Rust builds on the main branch #2798

Merged
merged 1 commit into from
Apr 18, 2023
Merged

ci: only cache Rust builds on the main branch #2798

merged 1 commit into from
Apr 18, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Apr 18, 2023 •
edited by ghost
Loading

This should avoid hitting the GitHub 10GB cache limit

This is bad:

image

we quickly run out of cache because some of the PRs are saving the cache.

Related issue (if exists)

Summary

🤖 Generated by Copilot at 8705c96

This pull request adds conditions to the save-cache steps of the check-rs and reusable-build workflows in .github/workflows. The conditions prevent the Rust build cache from being overwritten by non-main branches, which could cause issues for the CI/CD pipeline.

Walkthrough

🤖 Generated by Copilot at 8705c96

  • Restrict saving Rust build cache to main branch (link, link)

@Boshen
ci: only cache Rust builds on the main branch, and only read cache on…
8705c96 
… other branches

This should avoid hitting the GitHub 10GB cache limit
@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

⚠️ No Changeset found

Latest commit: 8705c96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Boshen Boshen changed the title ci: only cache Rust builds on the main branch, and only read cache on… ci: only cache Rust builds on the main branch, and only read cache on other branches Apr 18, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 18, 2023
@Boshen Boshen changed the title ci: only cache Rust builds on the main branch, and only read cache on other branches ci: only cache Rust builds on the main branch Apr 18, 2023
@Boshen Boshen added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit 1d235ea Apr 18, 2023
@Boshen Boshen deleted the only-cache-only-main branch April 18, 2023 06:44
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
@Boshen @siyou
ci: only cache Rust builds on the main branch (web-infra-dev#2798)
f20473e 
ci: only cache Rust builds on the main branch, and only read cache on other branches

This should avoid hitting the GitHub 10GB cache limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Boshen @IWANABETHATGUY @hyf0