Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "chore: 🤖 bump napi (#2717)" #2783

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Apr 17, 2023

This reverts commit 59c42ba.

Related issue (if exists)

Summary

  1. I noticed that the napi bump caused x86_64-apple-darwin test to fail, revert it for now.

🤖 Generated by Copilot at b531c55

Downgraded napi-related dependencies to fix compatibility issues with nodejs-resolver and Node.js 16. Added a placeholder test file for an import-empty-css-file fixture in the playground package. Removed an obsolete ignore_deps value from the check_rust_dependency script.

Walkthrough

🤖 Generated by Copilot at b531c55

  • Downgrade napi, napi-derive, and napi-sys dependencies from 2.12.x to 2.11.x in Cargo.toml files of root and node_binding crate to fix compatibility issue with nodejs-resolver crate (link, link)
  • Downgrade @napi-rs/cli devDependency from 2.15.2 to 2.14.2 in package.json and pnpm-lock.yaml files of node_binding crate to match napi version and avoid conflicts or bugs with newer CLI tool (link, link, link, link)
  • Add empty TypeScript file to test folder of import-empty-css-file fixture in playground package to create placeholder for writing test case for importing empty CSS files in rspack (link)
  • Empty ignore_deps array in check_rust_dependency.js script to remove irrelevant value of bitflags, which was resolved by napi upgrade to bitflags 2.x.x (link)
  • Add newline at end of package.json file of node_binding crate to ensure consistent formatting and avoid warnings or errors (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2023

⚠️ No Changeset found

Latest commit: b531c55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 17, 2023 09:56
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 17, 2023
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit 2d0fe8c Apr 17, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the fix/revert-update-napi branch April 17, 2023 10:01
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants