style: fix clippy warning #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- useless use of 'vec!' - needless borrow - redundant closure
|
|
|
siyou
added a commit
to siyou/rspack
that referenced
this pull request
May 14, 2023
- useless use of 'vec!' - needless borrow - redundant closure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 7508115
This pull request optimizes and refactors the
compilation.rsmodule in thenode_bindingcrate, which handles the conversion of JavaScript values to Rust values. It reduces memory usage and improves performance by avoiding unnecessary operations.Related issue (if exists)
Walkthrough
🤖 Generated by Copilot at 7508115
PathBufs incrates/node_binding/src/js_values/compilation.rs(link, link, link, link, link, link)self.innerwhen passing it tofrom_chunk_groupmethod in the same file (link)