Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nested byDependency not merge #2666

Merged
merged 3 commits into from
Apr 8, 2023
Merged

fix: nested byDependency not merge #2666

merged 3 commits into from
Apr 8, 2023

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Apr 7, 2023

Summary

fix CI: https://github.com/web-infra-dev/rspack/actions/runs/4637126393/jobs/8206218193

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8d11ba1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 7, 2023
@ahabhgk ahabhgk requested a review from bvanjoi April 7, 2023 13:51
@ahabhgk ahabhgk added this pull request to the merge queue Apr 8, 2023
Merged via the queue into main with commit 67bff68 Apr 8, 2023
@ahabhgk ahabhgk deleted the nested-by-dep branch April 8, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvanjoi bvanjoi bvanjoi approved these changes

@hardfist hardfist Awaiting requested review from hardfist

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahabhgk @bvanjoi