Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade typescript #2615

Merged
merged 7 commits into from
Apr 6, 2023
Merged

chore: Upgrade typescript #2615

merged 7 commits into from
Apr 6, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

Summary

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@IWANABETHATGUY IWANABETHATGUY requested a review from hardfist as a code owner April 4, 2023 11:01
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 50269f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IWANABETHATGUY IWANABETHATGUY enabled auto-merge April 4, 2023 11:01
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 4, 2023
@IWANABETHATGUY IWANABETHATGUY changed the title Upgrade typescript chore: Upgrade typescript Apr 4, 2023
hardfist
hardfist previously approved these changes Apr 4, 2023
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY requested a review from h-a-n-a as a code owner April 4, 2023 11:07
@h-a-n-a
Copy link
Contributor

h-a-n-a commented Apr 4, 2023

Could you rebase?

@IWANABETHATGUY
Copy link
Contributor Author

Could you rebase?

Done

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 6, 2023
Merged via the queue into main with commit 860bf43 Apr 6, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the upgrade-typescript branch April 6, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@hardfist hardfist Awaiting requested review from hardfist

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IWANABETHATGUY @h-a-n-a @hardfist