Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/create angular wip #2598

Conversation

zackarychapple
Copy link
Contributor

Summary

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

edusperoni and others added 29 commits March 10, 2023 12:45
…hore/create-angular

# Conflicts:
#	pnpm-lock.yaml
# Conflicts:
#	packages/rspack/src/compiler.ts
wip: change rspack config to more closely match ng webpack
@zackarychapple zackarychapple requested a review from hardfist as a code owner April 3, 2023 11:06
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

⚠️ No Changeset found

Latest commit: 8cb75ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2023

CLA assistant check
All committers have signed the CLA.

@hyf0 hyf0 added the p1-planned label Apr 3, 2023
@hardfist
Copy link
Contributor

is it ready for review now?

@zackarychapple
Copy link
Contributor Author

@hardfist we can, however the getCache and rebuildModule hooks should make it complete.

@IWANABETHATGUY
Copy link
Contributor

Closed in favor of #3009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants