Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove copy-plugin from cra example #2596

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Apr 3, 2023

Summary

since rspack supports builtins.copy there is no need to use copy-webpack-plugin in cra project, we should also update website

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

⚠️ No Changeset found

Latest commit: 0d8f4f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 3, 2023
@hardfist hardfist enabled auto-merge April 3, 2023 10:15
@hardfist hardfist added this pull request to the merge queue Apr 3, 2023
Merged via the queue into main with commit b0c6f44 Apr 3, 2023
@hardfist hardfist deleted the remove-copy-plugin branch April 3, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants