-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unify line endings for all files for any new clone #2541
chore: unify line endings for all files for any new clone #2541
Conversation
|
IMO, we should enforce |
Could you sign the CLA? And after discussing with the @web-infra-dev/rspack, we think it's better to enforce the end of line with |
CLA Signed. I still keep the change in |
Thanks for your contribution! Learn a lot about the line endings :). |
Summary
Motivation: To make .x file work under Linux.
What is changed: The files will be created with "LF" for any new clone, existing files will not be changed. About the details, please reference this great article about CRLF and LF: https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/
Have to say I am kind of confused, the CONTRIBUTING.md seems to be prepared for Linux, but ".x" is using CRLF as line endings, which make it complains "env: node\r: No such file". Note the strange "\r", which is the problem.
We cloud also add such content to .editorconfig to express intension better, I do not add it for now:
This should not cause any problem in Windows, there is no "bat" or "cmd" file in the repo.
Related issue (if exists)
Types of changes
Not sure, I guess it's "refactoring"?
Checklist
Does this change need to fill these checkbox?
pnpm run changeset
.