Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🤖 finish defineConfig #2267

Merged
merged 2 commits into from
Mar 16, 2023
Merged

feat: 🤖 finish defineConfig #2267

merged 2 commits into from
Mar 16, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

Summary

  1. Add defineConfig

Related issue (if exists)

Resolved #2263

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 6e591f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/cli Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/core Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IWANABETHATGUY IWANABETHATGUY changed the title chore: 🤖 finish defineConfig feat: 🤖 finish defineConfig Mar 15, 2023
@IWANABETHATGUY IWANABETHATGUY requested a review from hardfist March 15, 2023 06:09
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 15, 2023
@IWANABETHATGUY IWANABETHATGUY requested a review from ahabhgk March 15, 2023 06:09
ahabhgk
ahabhgk previously approved these changes Mar 15, 2023
@IWANABETHATGUY
Copy link
Contributor Author

@ahabhgk , CI has been fixed, would you mind approving again?

@IWANABETHATGUY IWANABETHATGUY merged commit a08d5d6 into main Mar 16, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the feat/define-config branch March 16, 2023 05:34
@so1ve so1ve mentioned this pull request Mar 16, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add type define helpers to improve intellisense
2 participants