Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: commonjs loading with extra output dir #2092

Merged
merged 2 commits into from
Mar 9, 2023
Merged

fix: commonjs loading with extra output dir #2092

merged 2 commits into from
Mar 9, 2023

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Mar 9, 2023

Summary

  • fix commonjs loading with extra output dir

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3bb7ea8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/core Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@underfin underfin changed the title fix: ix commonjs loading with extra output dir fix: fix commonjs loading with extra output dir Mar 9, 2023
@underfin underfin changed the title fix: fix commonjs loading with extra output dir fix: commonjs loading with extra output dir Mar 9, 2023
@underfin underfin force-pushed the fix-commonjs-output-dir branch from 7c72658 to 27dae61 Compare March 9, 2023 09:08
@h-a-n-a
Copy link
Contributor

h-a-n-a commented Mar 9, 2023

Please add changeset, or it will block publishing

@h-a-n-a h-a-n-a force-pushed the fix-commonjs-output-dir branch from 1abca7b to 0978d1f Compare March 9, 2023 10:41
@underfin underfin force-pushed the fix-commonjs-output-dir branch from 0978d1f to 3bb7ea8 Compare March 9, 2023 10:48
@underfin underfin merged commit d2072dd into main Mar 9, 2023
@underfin underfin deleted the fix-commonjs-output-dir branch March 9, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@underfin @h-a-n-a @hyf0