fix(progress): should not display empty progress bar (#2725)

web-infra-dev · Apr 12, 2023 · aa91ce7 · aa91ce7
1 parent b96a113
commit aa91ce7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/.changeset/shiny-squids-matter.md b/.changeset/shiny-squids-matter.md
@@ -0,0 +1,5 @@
+---
+"@rspack/binding": patch
+---
+
+fix(progress): should not display empty progress bar
diff --git a/crates/rspack_plugin_progress/src/lib.rs b/crates/rspack_plugin_progress/src/lib.rs
@@ -31,12 +31,6 @@ impl ProgressPlugin {
       ProgressStyle::with_template("{prefix} {bar:40.cyan/blue} {percent}% {wide_msg}")
         .expect("TODO:"),
     );
-    progress_bar.set_prefix(
-      options
-        .prefix
-        .clone()
-        .unwrap_or_else(|| "Rspack".to_string()),
-    );
     Self {
       options,
       progress_bar,
@@ -55,6 +49,13 @@ impl Plugin for ProgressPlugin {
 
   async fn make(&self, _ctx: PluginContext, _compilation: &Compilation) -> PluginMakeHookOutput {
     self.progress_bar.reset();
+    self.progress_bar.set_prefix(
+      self
+        .options
+        .prefix
+        .clone()
+        .unwrap_or_else(|| "Rspack".to_string()),
+    );
     self.modules_count.store(0, SeqCst);
     self.modules_done.store(0, SeqCst);
     self.progress_bar.set_message("make");