Skip to content

Commit

Permalink
fix: fix Compiler not getting freed after use (#8268)
Browse files Browse the repository at this point in the history
* fix: init

* feat: supp

* fix: segmentation fault

* Apply suggestions from code review
  • Loading branch information
h-a-n-a authored Nov 12, 2024
1 parent f23d638 commit 8f75992
Showing 2 changed files with 607 additions and 247 deletions.
Loading

2 comments on commit 8f75992

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-11-12 f23d638) Current Change
10000_big_production-mode + exec 44.6 s ± 770 ms 44.3 s ± 721 ms -0.68 %
10000_development-mode + exec 1.83 s ± 21 ms 1.78 s ± 29 ms -2.50 %
10000_development-mode_hmr + exec 643 ms ± 4.1 ms 642 ms ± 6.3 ms -0.16 %
10000_production-mode + exec 2.43 s ± 41 ms 2.42 s ± 38 ms -0.24 %
arco-pro_development-mode + exec 1.79 s ± 58 ms 1.77 s ± 32 ms -1.17 %
arco-pro_development-mode_hmr + exec 430 ms ± 1.3 ms 431 ms ± 1.4 ms +0.20 %
arco-pro_production-mode + exec 3.2 s ± 80 ms 3.23 s ± 64 ms +0.83 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.25 s ± 106 ms 3.23 s ± 67 ms -0.45 %
threejs_development-mode_10x + exec 1.59 s ± 7.7 ms 1.58 s ± 13 ms -0.37 %
threejs_development-mode_10x_hmr + exec 779 ms ± 10 ms 776 ms ± 11 ms -0.49 %
threejs_production-mode_10x + exec 4.97 s ± 42 ms 4.97 s ± 28 ms +0.09 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success

Please sign in to comment.