fix: contenthash should care about ChunkGraphModule#id (#2292)

* fix: contenthash should care about ChunkGraphModule#id * Changeset * Fix error
web-infra-dev · Mar 16, 2023 · 6d9eb8b · 6d9eb8b
1 parent 00f66b4
commit 6d9eb8b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/.changeset/seven-dancers-melt.md b/.changeset/seven-dancers-melt.md
@@ -0,0 +1,5 @@
+---
+"@rspack/binding": patch
+---
+
+fix: contenthash should care about ChunkGraphModule#id
diff --git a/crates/rspack_plugin_css/src/plugin.rs b/crates/rspack_plugin_css/src/plugin.rs
@@ -593,10 +593,16 @@ impl Plugin for CssPlugin {
 
     ordered_modules
       .iter()
-      .map(|module_identifier| compilation.module_graph.get_module_hash(module_identifier))
-      .for_each(|current| {
+      .map(|mgm| {
+        (
+          compilation.module_graph.get_module_hash(mgm),
+          compilation.chunk_graph.get_module_id(*mgm),
+        )
+      })
+      .for_each(|(current, id)| {
         if let Some(current) = current {
           current.hash(&mut hasher);
+          id.hash(&mut hasher);
         }
       });
 

diff --git a/crates/rspack_plugin_javascript/src/plugin.rs b/crates/rspack_plugin_javascript/src/plugin.rs
@@ -434,13 +434,17 @@ impl Plugin for JsPlugin {
     ordered_modules
       .iter()
       .map(|mgm| {
-        compilation
-          .module_graph
-          .get_module_hash(&mgm.module_identifier)
+        (
+          compilation
+            .module_graph
+            .get_module_hash(&mgm.module_identifier),
+          compilation.chunk_graph.get_module_id(mgm.module_identifier),
+        )
       })
-      .for_each(|current| {
+      .for_each(|(current, id)| {
         if let Some(current) = current {
           current.hash(&mut hasher);
+          id.hash(&mut hasher);
         }
       });