Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): printFileSize throw err when set output.filename query #650

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

fireairforce
Copy link
Member

Summary

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 7fd8a00
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/655deb2b70b75200084bf431
😎 Deploy Preview https://deploy-preview-650--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chenjiahan
❌ wudong.zelda


wudong.zelda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chenjiahan chenjiahan changed the title fix(rsbuild): printFileSize throw err when set output.filename query fix(core): printFileSize throw err when set output.filename query Nov 22, 2023
@chenjiahan chenjiahan enabled auto-merge (squash) November 22, 2023 11:51
@chenjiahan
Copy link
Member

Awesome!

@chenjiahan chenjiahan merged commit 9c436c5 into main Nov 22, 2023
9 of 10 checks passed
@chenjiahan chenjiahan deleted the fix-printSize branch November 22, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants