Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-rsbuild): remove public/.gitkeep file #4748

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

chenjiahan
Copy link
Member

Summary

We added a .gitkeep file to the templates to demonstrate the use of the public directory. But it will generate a dist/.gitkeep file and might confuse users.

This PR removes the public/.gitkeep file and we will add a public/favicon.ico to the templates later.

Related Links

resolve #4666

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit f701d3e
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67cea075e646c60008613312
😎 Deploy Preview https://deploy-preview-4748--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 2ef1637 into main Mar 10, 2025
12 checks passed
@chenjiahan chenjiahan deleted the remove_gitkeep_0310 branch March 10, 2025 08:26
@chenjiahan chenjiahan mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant