Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): revert all cases to CJS to fix timeout #4616

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Feb 21, 2025

Summary

Since the merge of #4579, our E2E has started to timeout frequently.

After investigation, it appears that this is not related to the implementation of Rsbuild itself, but may be related to Playwright's transformation of ESM.

As it is difficult to locate the root cause, this PR reverts the previous changes to fix CI.

The minimal reproduction cases: pnpm run e2e:webpack cases/alias

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit e75920a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67b7e7b0bbc580000853ddd9
😎 Deploy Preview https://deploy-preview-4616--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 49 (🔴 down 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 5030253 into main Feb 21, 2025
10 of 11 checks passed
@chenjiahan chenjiahan deleted the revert_e2e_to_cjs_0220 branch February 21, 2025 02:54
@chenjiahan chenjiahan mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant