Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postcssrc cache may cause memory leak #4604

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

chenjiahan
Copy link
Member

Summary

When running Rsbuild E2E tests, dozens of postcss configurations were stored in postcsssrcCache, which caused memory usage.

We can move postcssrcCache to the plugin scope to avoid memory leaks.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 138fee9
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67b6a6be9bc4f70008cf7ed9
😎 Deploy Preview https://deploy-preview-4604--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 49 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit fa53580 into main Feb 20, 2025
12 checks passed
@chenjiahan chenjiahan deleted the postcssrc_cache_0220 branch February 20, 2025 04:18
@chenjiahan chenjiahan mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant