Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache): add env files to buildDependencies #4601

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

chenjiahan
Copy link
Member

Summary

Add env files to build dependencies, so that the build cache can be invalidated when the env files are changed. Changes in env are likely to affect the build results.

Currently, this can only be implemented in the Rsbuild CLI. We need to consider how to provide similar implementations for users who use the JavaScript API.

Related Links

resolve #4586

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit d6e3857
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67b5efa4c20fdf0007a768b8
😎 Deploy Preview https://deploy-preview-4601--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 52 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 2a69df3 into main Feb 19, 2025
12 checks passed
@chenjiahan chenjiahan deleted the build_cache_env_0219 branch February 19, 2025 15:26
@chenjiahan chenjiahan mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: buildCache not invalidated on environment variable change
1 participant