Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should writeToDisk correctly when environment writeToDisk configuration same #4269

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Dec 25, 2024

Summary

should writeToDisk correctly when the environment writeToDisk configuration is the same

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 5ca37d0
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/676bc9aa6ce2e10008dc122c
😎 Deploy Preview https://deploy-preview-4269--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@9aoy 9aoy requested a review from chenjiahan December 25, 2024 09:02
Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit b00740a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/676bc9eac441f100081ca5fd
😎 Deploy Preview https://deploy-preview-4269--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit d2730f9 into main Dec 25, 2024
9 checks passed
@chenjiahan chenjiahan deleted the environment-write-to-disk-same branch December 25, 2024 09:23
@chenjiahan chenjiahan mentioned this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants