Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): should transpile all Vue SFC #3964

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

By default, Rsbuild only compiles JavaScript files in the current directory and TypeScript and JSX files in all directories. It does not compile JavaScript files under node_modules.

But the scripts from Vue SFC should be always transpiled, adding /\.vue.js$/ to source.include can fix this.

Related Links

#3956

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1fe402d
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6734b7edaaebd300080aec1f
😎 Deploy Preview https://deploy-preview-3964--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 71 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 7f20aa1 into main Nov 14, 2024
10 checks passed
@chenjiahan chenjiahan deleted the vue_sfc_1113 branch November 14, 2024 01:13
@chenjiahan chenjiahan mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant