Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the assignment method of host in baseUrl #3943

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

junxiongchu
Copy link
Contributor

Summary

When local development is allowed and the browser is automatically opened, the host of baseUrl uses the server host configuration by default, instead of directly defaulting to hard-coding localhost
(although it can be specified through open, it is more troublesome for those who use the default open configuration)

Related Links

20241112-112748
20241112-112756

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 5ba6f79
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6732cb64a5dfce0008d9c9ed
😎 Deploy Preview https://deploy-preview-3943--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🔴 down 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@junxiongchu junxiongchu marked this pull request as draft November 12, 2024 03:45
@junxiongchu junxiongchu reopened this Nov 12, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


储俊雄 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chenjiahan chenjiahan reopened this Nov 13, 2024
@chenjiahan
Copy link
Member

Thank you for your contribution!

I think this fix is necessary, so I will merge this PR and make it work as expected.

@chenjiahan chenjiahan marked this pull request as ready for review November 13, 2024 04:20
@chenjiahan chenjiahan merged commit 81faeac into web-infra-dev:main Nov 13, 2024
14 of 15 checks passed
@9aoy 9aoy mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants