Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): use Rslib to build #3939

Merged
merged 18 commits into from
Nov 12, 2024
Merged

refactor(core): use Rslib to build #3939

merged 18 commits into from
Nov 12, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Nov 11, 2024

Summary

  • Use Rslib to build the @rsbuild/core package.
  • Remove @modern-js/module-tools dependency.
  • Remove the compiled related tsconfig paths, import directly from the compiled folder to avoid depending on tsc-alias.
  • Use tsc to generate types because there are still some pending issues of Rslib DTS generation.

Related Links

https://github.com/web-infra-dev/rslib

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit f6a6dcb
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/673318a4b5029200089c06e1
😎 Deploy Preview https://deploy-preview-3939--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan
Copy link
Member Author

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Nov 11, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
plugins ❌ failure
rspress ❌ failure
rslib ❌ failure
examples ❌ failure

@chenjiahan
Copy link
Member Author

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Nov 11, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
plugins ❌ failure
rspress ❌ failure
rslib ❌ failure
examples ❌ failure

@chenjiahan
Copy link
Member Author

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Nov 12, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
plugins ✅ success
rspress ✅ success
rslib ✅ success
examples ✅ success

@chenjiahan chenjiahan merged commit 5439dde into main Nov 12, 2024
11 checks passed
@chenjiahan chenjiahan deleted the core_to_rslib_1111 branch November 12, 2024 09:07
@9aoy 9aoy mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants