Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin/assets-retry): calculate the times independently in each retry #3852

Merged
merged 9 commits into from
Oct 29, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Oct 28, 2024

Summary

each retry should be independent.

before this pull request,

when two "max": 3 retries are parallel, the same url request may be that one is 1, 3, the other is 2, so number of times of each retry is not fixed.

after this pull request,

first: 1 2 3
second: 1 2 3

every request retried three times

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 3d63ff1
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67207ac531bcda0008bdc6b9
😎 Deploy Preview https://deploy-preview-3852--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 62 (🔴 down 16 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter marked this pull request as ready for review October 28, 2024 12:29
@SoonIter SoonIter changed the title fix(plugin/assets-retry): calculate the context separately in each retry fix(plugin/assets-retry): calculate the times independently in each retry Oct 28, 2024
@SoonIter SoonIter requested a review from chenjiahan October 28, 2024 12:46
@chenjiahan chenjiahan merged commit d470bed into main Oct 29, 2024
9 checks passed
@chenjiahan chenjiahan deleted the asyncChunkRetry branch October 29, 2024 08:11
@chenjiahan chenjiahan mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants