Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): enable full type check and fix type issue #2332

Merged
merged 1 commit into from
May 14, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Rsbuild uses Modern.js Module to build packages, and it uses rollup-plugin-dts to generate dts files by default. But the rollup-plugin-dts can not perform a full type checking and does not have complete type generating supports (for example, cannot handle namespace).

This PR changed the build config and uses tsc for type checking and dts generation.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented May 14, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 594350c
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6642f3e64bd41f0008834abb
😎 Deploy Preview https://deploy-preview-2332--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 75f658f into main May 14, 2024
11 checks passed
@chenjiahan chenjiahan deleted the type_check_0514 branch May 14, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant